Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 13351002: First step for fixing Issue 9416. (Closed)

Created:
7 years, 8 months ago by siva
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First step for fixing Issue 9416. Committed: https://code.google.com/p/dart/source/detail?r=20760

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -47 lines) Patch
M runtime/lib/isolate.cc View 1 2 3 1 chunk +23 lines, -21 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 5 chunks +12 lines, -19 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A tests/isolate/spawn_uri_nested_child1_vm_isolate.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/isolate/spawn_uri_nested_child2_vm_isolate.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/isolate/spawn_uri_nested_vm_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 8 months ago (2013-03-30 00:30:00 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/13351002/diff/11001/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): https://codereview.chromium.org/13351002/diff/11001/runtime/lib/isolate.cc#newcode175 runtime/lib/isolate.cc:175: Dart_EnterScope(); Don't you want to move the ...
7 years, 8 months ago (2013-04-01 23:45:06 UTC) #2
siva
https://codereview.chromium.org/13351002/diff/11001/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): https://codereview.chromium.org/13351002/diff/11001/runtime/lib/isolate.cc#newcode175 runtime/lib/isolate.cc:175: Dart_EnterScope(); On 2013/04/01 23:45:06, Ivan Posva wrote: > Don't ...
7 years, 8 months ago (2013-04-01 23:51:41 UTC) #3
siva
7 years, 8 months ago (2013-04-02 00:01:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r20760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698