Issue 13348002: Make pub warning-clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13348002: Make pub warning-clean. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make pub warning-clean. This also works around issue 9535 in scheduled_test. Committed: https://code.google.com/p/dart/source/detail?r=20702

Patch Set 2 : Code review change. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_test.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	utils/tests/pub/io_test.dart	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/13348002/diff/1/utils/tests/pub/io_test.dart File utils/tests/pub/io_test.dart (right): https://codereview.chromium.org/13348002/diff/1/utils/tests/pub/io_test.dart#newcode193 utils/tests/pub/io_test.dart:193: var txtPath = path.join(temp, "test.txt"); How about just ...

7 years, 8 months ago (2013-03-29 23:57:47 UTC) #2

nweiz

https://codereview.chromium.org/13348002/diff/1/utils/tests/pub/io_test.dart File utils/tests/pub/io_test.dart (right): https://codereview.chromium.org/13348002/diff/1/utils/tests/pub/io_test.dart#newcode193 utils/tests/pub/io_test.dart:193: var txtPath = path.join(temp, "test.txt"); On 2013/03/29 23:57:47, Bob ...

7 years, 8 months ago (2013-03-30 00:07:09 UTC) #3

nweiz

7 years, 8 months ago (2013-03-30 00:07:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20702 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13348002: Make pub warning-clean. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change. #

Messages