Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334203002: Compute Compiler.proxyConstant on demand. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -38 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +12 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 5 chunks +35 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 5 chunks +58 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/minimal_resolution_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/ssa/nodes.dart#newcode885 pkg/compiler/lib/src/ssa/nodes.dart:885: /// Returns `true` if [typeMask] contains [cls]. The need ...
5 years, 3 months ago (2015-09-11 11:48:40 UTC) #2
karlklose
LGTM! https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#newcode2994 pkg/compiler/lib/src/js_backend/backend.dart:2994: needsInt(registry); // Needed for accessing the type variable ...
5 years, 3 months ago (2015-09-11 12:21:15 UTC) #3
Johnni Winther
https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/1334203002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#newcode2994 pkg/compiler/lib/src/js_backend/backend.dart:2994: needsInt(registry); // Needed for accessing the type variable literal. ...
5 years, 3 months ago (2015-09-11 12:38:36 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-11 12:47:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bda5146f40e034eb7bcfedd59bfe7f7dec6b0ba0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698