Issue 133373010: "Reverting 32572"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133373010: "Reverting 32572" (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

"Reverting 32572" my local client was in a bad state, changes don't reflect the intended patch, which was just to add "Fail" as an option for template_binding/test/custom_element_bindings_test Committed: https://code.google.com/p/dart/source/detail?r=32573

Patch Set 1 #

Patch Set 2 : add fail to custom_element_bindings_test #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	pkg/pkg.status	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Committed patchset #2 manually as r32573 (presubmit successful).

6 years, 10 months ago (2014-02-11 19:27:11 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages