Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333313002: Fix conversion from Uri to File in test, to use File.fromUri(). (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix conversion from Uri to File in test, to use File.fromUri(). BUG= R=wibling@google.com Committed: https://github.com/dart-lang/sdk/commit/e14568cf83adc05e4c7dfe281fa369c653b01b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/lookup_map/test/version_check_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bill Hesse
5 years, 3 months ago (2015-09-11 14:19:22 UTC) #2
Bill Hesse
5 years, 3 months ago (2015-09-11 14:20:17 UTC) #4
wibling
lgtm
5 years, 3 months ago (2015-09-11 14:21:14 UTC) #5
Bill Hesse
Committed patchset #1 (id:1) manually as e14568cf83adc05e4c7dfe281fa369c653b01b77 (presubmit successful).
5 years, 3 months ago (2015-09-11 14:21:49 UTC) #6
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-11 16:29:38 UTC) #8
Message was sent while issue was closed. 
lgtm!

Thanks again!

Powered by Google App Engine
This is Rietveld 408576698