Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1332963002: Remove pkg/petitparser and pkg/intl from checkout. (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years ago
Reviewers:
ricow1, ahe, sra1
CC:
reviews_dartlang.org, Alan Knight
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove third_party/pkg/petitparser and third_party/pkg/intl BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/58ea2fbce68cc8dd6cbfa1bb17175e8c10639379

Patch Set 1 #

Patch Set 2 : Also remove package intl, and site/try's dependence on it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M DEPS View 1 4 chunks +0 lines, -6 lines 0 comments Download
M site/try/app.yaml View 1 1 chunk +0 lines, -4 lines 0 comments Download
M site/try/build_try.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Bill Hesse
5 years, 3 months ago (2015-09-10 16:39:49 UTC) #2
Bill Hesse
These packages are only used in observatory, which has its own package root downloaded from ...
5 years, 3 months ago (2015-09-10 17:01:19 UTC) #4
Bill Hesse
Ping. I can't find any emails or discussion we had about this, where we said ...
5 years ago (2015-12-15 15:56:22 UTC) #5
ricow1
I was not looking at the second patch set no, sorry about that. LGTM
5 years ago (2015-12-16 08:14:46 UTC) #6
Bill Hesse
Committed patchset #2 (id:20001) manually as 58ea2fbce68cc8dd6cbfa1bb17175e8c10639379 (presubmit successful).
5 years ago (2015-12-16 13:48:24 UTC) #8
sra1
5 years ago (2015-12-16 22:21:48 UTC) #10
Message was sent while issue was closed.
Please put Intl back.
It is used by benchmarks.

It might be that intl is a little old.
In that case I would like you to put it back so we re-establish the baseline
against with recent compiler changes, then update it to a version recommended by
alanknight@

Powered by Google App Engine
This is Rietveld 408576698