Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1332923005: Remove remaining uses of null's absolute address from non-IA32. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove remaining uses of null's absolute address from non-IA32. Note not every file is touched for every architecture because some already load null via Thread in most places. Don't use absolute stack overflow address when precompiling. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/690cccf03c66c7d364f13e053b50d1118ae9ae4c

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -90 lines) Patch
M runtime/vm/assembler_arm.cc View 1 2 4 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 5 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 8 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 10 chunks +11 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 9 chunks +9 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 5 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 19 chunks +19 lines, -19 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 19 chunks +19 lines, -19 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-10 22:42:53 UTC) #2
Florian Schneider
lgtm. https://chromiumcodereview.appspot.com/1332923005/diff/20001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://chromiumcodereview.appspot.com/1332923005/diff/20001/runtime/vm/assembler_x64.cc#newcode3035 runtime/vm/assembler_x64.cc:3035: LoadObject(TMP, Object::null_object()); TMP should be only used inside ...
5 years, 3 months ago (2015-09-11 13:42:41 UTC) #3
rmacnak
https://codereview.chromium.org/1332923005/diff/20001/runtime/vm/intrinsifier_arm.cc File runtime/vm/intrinsifier_arm.cc (right): https://codereview.chromium.org/1332923005/diff/20001/runtime/vm/intrinsifier_arm.cc#newcode76 runtime/vm/intrinsifier_arm.cc:76: __ CompareObject(R0, Type::ZoneHandle(Type::DynamicType())); On 2015/09/11 13:42:40, Florian Schneider wrote: ...
5 years, 3 months ago (2015-09-11 18:34:02 UTC) #4
rmacnak
5 years, 3 months ago (2015-09-11 18:34:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
690cccf03c66c7d364f13e053b50d1118ae9ae4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698