Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133273011: Revert "Rename internal library dart:_collection-dev to dart:_internal." (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Rename internal library dart:_collection-dev to dart:_internal." Dartium needs updating too. Committed: https://code.google.com/p/dart/source/detail?r=31827 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31877

Patch Set 1 #

Patch Set 2 : reapply after revert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -2341 lines) Patch
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dartutils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + runtime/lib/collection_dev_patch.dart View 1 1 chunk +0 lines, -3 lines 0 comments Download
D runtime/lib/collection_dev_sources.gypi View 1 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/function_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/lib/internal_patch.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/internal_sources.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/invocation_mirror_patch.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/mirrors_patch.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/lib/object_patch.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/typed_data.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object_store.h View 1 4 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 1 19 chunks +148 lines, -148 lines 0 comments Download
M samples/third_party/pop-pop-win/app_package/game_app.dart.js View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/pop-pop-win/app_package/game_app.dart.precompiled.js View 1 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_collection_dev/collection_dev.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
D sdk/lib/_collection_dev/collection_dev_sources.gypi View 1 1 chunk +0 lines, -17 lines 0 comments Download
D sdk/lib/_collection_dev/iterable.dart View 1 1 chunk +0 lines, -1167 lines 0 comments Download
D sdk/lib/_collection_dev/list.dart View 1 1 chunk +0 lines, -307 lines 0 comments Download
D sdk/lib/_collection_dev/lists.dart View 1 1 chunk +0 lines, -99 lines 0 comments Download
D sdk/lib/_collection_dev/print.dart View 1 1 chunk +0 lines, -17 lines 0 comments Download
D sdk/lib/_collection_dev/sort.dart View 1 1 chunk +0 lines, -344 lines 0 comments Download
D sdk/lib/_collection_dev/symbol.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/lib/collection_dev_patch.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/interceptors.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/lib/internal_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/async/async.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/collection.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/core.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/core/symbol.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/internal/internal.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/internal_sources.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/lib/internal/iterable.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/list.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/lists.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/print.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/sort.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/internal/symbol.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 2 chunks +0 lines, -3 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/import_private_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
TBR.
6 years, 11 months ago (2014-01-15 12:26:59 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r31827 (presubmit successful).
6 years, 11 months ago (2014-01-15 12:28:46 UTC) #2
floitsch
LGTM. :(
6 years, 11 months ago (2014-01-15 12:54:45 UTC) #3
Lasse Reichstein Nielsen
Reverted again, needs Dartium changes too.
6 years, 11 months ago (2014-01-15 13:14:30 UTC) #4
Lasse Reichstein Nielsen
6 years, 11 months ago (2014-01-16 12:08:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r31877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698