Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 13327009: Increase the default test timeout for scheduled tests on Windows. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Increase the default test timeout for scheduled tests on Windows. Committed: https://code.google.com/p/dart/source/detail?r=20695

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M pkg/scheduled_test/test/descriptor_test.dart View 1 chunk +6 lines, -0 lines 2 comments Download
M pkg/scheduled_test/test/metatest.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 8 months ago (2013-03-29 20:27:56 UTC) #1
Bob Nystrom
This is an awfully big patch for such a simple change. How about making scheduled ...
7 years, 8 months ago (2013-03-29 21:08:31 UTC) #2
nweiz
Windows isn't slow everywhere. This is really a problem that's local to our buildbots. https://codereview.chromium.org/13327009/diff/1/pkg/scheduled_test/test/descriptor_test.dart ...
7 years, 8 months ago (2013-03-29 21:38:32 UTC) #3
Bob Nystrom
LGTM then.
7 years, 8 months ago (2013-03-29 21:39:01 UTC) #4
nweiz
7 years, 8 months ago (2013-03-29 21:47:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698