Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1332403002: Revert "Update status of try tests on dartium" (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Update status of try tests on dartium" The problem was fixed in f850f312e3f166d54735d54060660c4daccb9948. This reverts commit d044fc84eeee983d6f3493bf3bb32efd5da7ae91. Fix conversion from Uri to File in test, to use File.fromUri(). BUG= TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/078d5b79a5683c9330e761abd6657d535937aea6

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tests/try/try.status View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
Committed patchset #2 (id:20001) manually as 078d5b79a5683c9330e761abd6657d535937aea6 (presubmit successful).
5 years, 3 months ago (2015-09-11 14:30:40 UTC) #1
Johnni Winther
5 years, 3 months ago (2015-09-11 14:33:20 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698