Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 133213011: Avoid "cannot create a Trace from null" errors in pub. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Avoid "cannot create a Trace from null" errors in pub. These errors cover up other errors. They were caused because dart:io produces asynchronous errors without associated stack traces, and when running without --trace or --verbose pub doesn't add its own trace information to these errors. R=alanknight@google.com BUG=16470 Committed: https://code.google.com/p/dart/source/detail?r=32267

Patch Set 1 #

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M sdk/lib/_internal/pub/lib/src/utils.dart View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 10 months ago (2014-02-03 22:26:23 UTC) #1
Alan Knight
lgtm
6 years, 10 months ago (2014-02-03 22:51:17 UTC) #2
nweiz
6 years, 10 months ago (2014-02-03 23:03:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698