Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1331843004: Addition bug fixes for new task model (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -58 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +68 lines, -56 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
There is one more failing unit test that I know of, which I'll address in ...
5 years, 3 months ago (2015-09-10 14:56:31 UTC) #2
scheglov
LGTM
5 years, 3 months ago (2015-09-10 15:00:50 UTC) #3
Brian Wilkerson
5 years, 3 months ago (2015-09-10 15:10:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b925adf828233bde38786bd8123462840906dd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698