Issue 1331193002: Use a source_set instead of static_library for libdart_embedder_noio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1331193002: Use a source_set instead of static_library for libdart_embedder_noio (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use a source_set instead of static_library for libdart_embedder_noio Some linkers (like libtool) complain when trying to create a static_library with no sources. A source_set communicates the same thing to GN without upsetting the linker. patch from issue 1313973005 at patchset 1 (http://crrev.com/1313973005#ps1) BUG= Committed: https://github.com/dart-lang/sdk/commit/38ab14f73428cb8252e26183046693299f2ff41b

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Cutch

5 years, 3 months ago (2015-09-10 16:33:06 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
38ab14f73428cb8252e26183046693299f2ff41b (presubmit successful).