This is a fixed up version of:

This is a fixed up version of:
https://codereview.chromium.org/1305183010/

- Reorder the priority of flags in the test harness when passed to the VM:
  default flags, file flags, command line flags
- Ensure to not enable assertions when not being requested.

Peter, any reason to not move the flags in to the
configuration file?  Why don't we actually have all of them in there? (not
that I want to move them, I am just currious why we don't add them in
there, it seems more logical to me)

BUG=
R=iposva@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/dd7767d95eda87054844e0b24ebd2ce9b04354bb

Committed: https://github.com/dart-lang/sdk/commit/2e22f41612843a8791104803b6e906e5eb2ac358

[ricow1, 2015-09-04 06:58:51]

ricow@google.com changed reviewers:
+ ahe@google.com, iposva@google.com

[ricow1, 2015-09-04 07:13:03]

ricow@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-09-04 08:32:08]

lgtm

[Ivan Posva, 2015-09-04 17:42:22]

LGTM and many thanks for figuring out how to restructure the test harness.

-Ivan

[ricow1, 2015-09-07 05:58:11]

Committed patchset #2 (id:20001) manually as
dd7767d95eda87054844e0b24ebd2ce9b04354bb (presubmit successful).

[ricow1, 2015-09-11 10:43:29]

please take another look, added flag for analyzer, and marked the new test as
failing on non vm platforms

[Bill Hesse, 2015-09-11 11:09:39]

I don't see the flag for analyzer change.  It is hard to view the diffs between
patch sets, because it is rebased between them.  The status change looks good. 
If you need a new CL to commit the changes anyway, can I look at that instead?

https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
tests/standalone/standalone.status:21: no_assert_test: Fail, OK # This is
testing a vm flag.
Why not skip?  Because it is worthwhile making sure this does not crash other
platforms?  A good idea, if that is it.

[ricow1, 2015-09-14 05:56:27]

On 2015/09/11 11:09:39, Bill Hesse wrote:
> I don't see the flag for analyzer change.  It is hard to view the diffs
between
> patch sets, because it is rebased between them.  The status change looks good.

> If you need a new CL to commit the changes anyway, can I look at that instead?
the compiler changes are in tools/testing/dart/compiler_configuration.dart.

Sorry about the rebase of the parser.cc, there are no changes in that file, so
basically the changes to status and compiler_configuration.


> 
>
https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
> File tests/standalone/standalone.status (right):
> 
>
https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
> tests/standalone/standalone.status:21: no_assert_test: Fail, OK # This is
> testing a vm flag.
> Why not skip?  Because it is worthwhile making sure this does not crash other
> platforms?  A good idea, if that is it.

[ricow1, 2015-09-14 05:56:58]

TBR

https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1330643003/diff/80001/tests/standalone/standa...
tests/standalone/standalone.status:21: no_assert_test: Fail, OK # This is
testing a vm flag.
On 2015/09/11 11:09:39, Bill Hesse wrote:
> Why not skip?  Because it is worthwhile making sure this does not crash other
> platforms?  A good idea, if that is it.

Yes

[ricow1, 2015-09-14 05:58:27]

Committed patchset #5 (id:80001) manually as
2e22f41612843a8791104803b6e906e5eb2ac358 (presubmit successful).