Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1330533002: Revert "Allow individual unicode surrogates strings" (Closed)

Created:
5 years, 3 months ago by Alan Knight
Modified:
5 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Allow individual unicode surrogates strings" This reverts commit 6ba411ffc9f0122855054e5f3056c7d296c2161d. BUG= Committed: https://github.com/dart-lang/sdk/commit/a8b3972919b542cfedf3c72490a7a07bea6e404a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 2 chunks +4 lines, -26 lines 0 comments Download
M runtime/vm/unicode.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
TBR Missed some other tests that exercise this.
5 years, 3 months ago (2015-09-02 22:12:09 UTC) #2
Alan Knight
5 years, 3 months ago (2015-09-02 22:12:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8b3972919b542cfedf3c72490a7a07bea6e404a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698