Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1330363002: Remove fake_async from third_party/pkg. (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bill Hesse
It looks like the package was only used for 2 days in July 2014.
5 years, 3 months ago (2015-09-10 16:14:05 UTC) #2
Bill Hesse
This package is also in the dev_dependencies of third_party/pkg/test and third_party/pkg/pool. I think that our ...
5 years, 3 months ago (2015-09-10 17:22:24 UTC) #3
nweiz
On 2015/09/10 17:22:24, Bill Hesse wrote: > This package is also in the dev_dependencies of ...
5 years, 3 months ago (2015-09-10 20:47:51 UTC) #4
Bill Hesse
Please take another look. I think this should be fine to remove now.
5 years ago (2015-12-15 15:36:54 UTC) #5
nweiz
lgtm
5 years ago (2015-12-15 22:10:45 UTC) #6
Bill Hesse
5 years ago (2015-12-16 13:16:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a74f54faf08e4d4ccb7bc24b946809bbb5a87c95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698