Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1330303002: Make Map constructor external to allow dart2js to specialize it. (Closed)

Created:
5 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Map constructor external to allow dart2js to specialize it. Committed: https://github.com/dart-lang/sdk/commit/7464947ca0c112bf2723615014d7a3ee7e50f683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/lib/map_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 2 chunks +5 lines, -1 line 0 comments Download
M sdk/lib/core/map.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 3 months ago (2015-09-10 11:25:23 UTC) #2
Kevin Millikin (Google)
LVGTM.
5 years, 3 months ago (2015-09-11 10:47:23 UTC) #3
Lasse Reichstein Nielsen
5 years, 3 months ago (2015-09-11 11:06:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7464947ca0c112bf2723615014d7a3ee7e50f683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698