Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 132963002: Read Intl.message examples argument as a map, not a string (Closed)

Created:
6 years, 11 months ago by Alan Knight
Modified:
6 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Read Intl.message examples argument as a map, not a string BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=31749

Patch Set 1 #

Total comments: 1

Patch Set 2 : A better way of doing this, courtesy of the analyzer #

Patch Set 3 : Fixed comment #

Patch Set 4 : Tweaks for the test framework #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -23 lines) Patch
M pkg/intl/lib/extract_messages.dart View 1 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/intl/lib/intl.dart View 1 2 1 chunk +30 lines, -16 lines 0 comments Download
M pkg/intl/lib/src/intl_message.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A pkg/intl/test/message_extraction/examples_parsing_test.dart View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/make_hardcoded_translation.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
Which we do by reading it as JSON, which restricts what you can do in ...
6 years, 11 months ago (2014-01-10 00:49:47 UTC) #1
Emily Fortuna
lgtm https://codereview.chromium.org/132963002/diff/1/pkg/intl/lib/intl.dart File pkg/intl/lib/intl.dart (right): https://codereview.chromium.org/132963002/diff/1/pkg/intl/lib/intl.dart#newcode132 pkg/intl/lib/intl.dart:132: * Returns a message that can be internationalized. ...
6 years, 11 months ago (2014-01-10 01:40:56 UTC) #2
Alan Knight
Did this entirely differently so JSON is no longer required. Please take (another) look.
6 years, 11 months ago (2014-01-10 23:57:06 UTC) #3
Emily Fortuna
lgtm
6 years, 11 months ago (2014-01-11 00:07:56 UTC) #4
Alan Knight
6 years, 11 months ago (2014-01-13 17:58:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r31749 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698