Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1329183002: Fix source spans for scalars. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom, pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/yaml@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/yaml_node.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/yaml_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
5 years, 3 months ago (2015-09-08 23:54:20 UTC) #1
pquitslund
LGTM. Thanks!
5 years, 3 months ago (2015-09-08 23:55:05 UTC) #3
Bob Nystrom
Oops. LGTM!
5 years, 3 months ago (2015-09-09 00:30:31 UTC) #4
nweiz
5 years, 3 months ago (2015-09-09 00:38:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bf510323b4791fc744d39c14d55afa33e176429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698