Issue 132903009: Fix bug in iteration over DelaySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132903009: Fix bug in iteration over DelaySet. (Closed)

Created:
6 years, 11 months ago by Florian Schneider

Modified:
6 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix bug in iteration over DelaySet. The set may be modfied while iterating over it. I create a temporary vector with a copy of the iterator range for iteration. This seems to fix the frequent crash with certain Polymer apps in Dartium BUG=dartbug.com/16231 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32063 Committed: https://code.google.com/p/dart/source/detail?r=32070

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	runtime/vm/gc_marker.cc	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Florian Schneider

Committed patchset #1 manually as r32063 (presubmit successful).

6 years, 11 months ago (2014-01-28 10:26:03 UTC) #3

Florian Schneider

TBR: Updated CL with fixed Windows compilation: MSVS does not like the use of multimap::value_type, ...

6 years, 10 months ago (2014-01-28 15:26:09 UTC) #4

Florian Schneider

6 years, 10 months ago (2014-01-28 15:31:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r32070 (presubmit successful).