Issue 132903004: Fix profile sample buffer leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132903004: Fix profile sample buffer leak (Closed)

Created:
6 years, 11 months ago by Cutch

Modified:
6 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	runtime/vm/profiler.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Cutch

Committed patchset #1 manually as r31696 (presubmit successful).

6 years, 11 months ago (2014-01-10 17:24:16 UTC) #2

Ivan Posva

6 years, 11 months ago (2014-01-10 17:38:55 UTC) #3

Message was sent while issue was closed.

LGTM

We should probably switch to a shared sample buffer, so that we do not end up
with shutdown races (or leaks).

-Ivan