Issue 1328613002: Fix a performance bug with FileLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328613002: Fix a performance bug with FileLocation. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/source_span@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a performance bug with FileLocation. The bug was actually located in SourceLocation. The constructor accesses this.line and `this.column` in preference to the arguments it was passed, which was fine for normal SourceLocations but for FileLocations caused two binary searches to be performed every time a location was instantiated. R=rnystrom@google.com Committed: https://github.com/dart-lang/source_span/commit/97fc7da1ec71c5d76e31df5dff4815c5502c666c

Patch Set 1 #

Patch Set 2 : update pubspec #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/location.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 3 months ago (2015-09-02 18:44:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
97fc7da1ec71c5d76e31df5dff4815c5502c666c (presubmit successful).

Expand Messages | Collapse Messages