Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328503003: Add Server.isClosed and Client.isClosed. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +10 lines, -0 lines 0 comments Download
M lib/src/client.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/peer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/server.dart View 2 chunks +4 lines, -1 line 0 comments Download
M lib/src/two_way_stream.dart View 1 3 chunks +6 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/client/stream_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/server/stream_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nweiz
5 years, 3 months ago (2015-09-03 01:00:18 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1328503003/diff/1/lib/src/two_way_stream.dart File lib/src/two_way_stream.dart (right): https://codereview.chromium.org/1328503003/diff/1/lib/src/two_way_stream.dart#newcode42 lib/src/two_way_stream.dart:42: bool get isClosed => _isClosed; Can this just be ...
5 years, 3 months ago (2015-09-03 18:13:03 UTC) #2
nweiz
Code review changes
5 years, 3 months ago (2015-09-08 21:17:12 UTC) #3
nweiz
Code review changes
5 years, 3 months ago (2015-09-08 21:17:28 UTC) #4
nweiz
https://codereview.chromium.org/1328503003/diff/1/lib/src/two_way_stream.dart File lib/src/two_way_stream.dart (right): https://codereview.chromium.org/1328503003/diff/1/lib/src/two_way_stream.dart#newcode42 lib/src/two_way_stream.dart:42: bool get isClosed => _isClosed; On 2015/09/03 18:13:03, Bob ...
5 years, 3 months ago (2015-09-08 21:17:32 UTC) #5
nweiz
Ping!
5 years, 3 months ago (2015-09-14 22:11:26 UTC) #6
Bob Nystrom
lgtm
5 years, 3 months ago (2015-09-14 23:07:48 UTC) #7
nweiz
5 years, 3 months ago (2015-09-15 00:27:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b41c5e5898efb094d749d148caf02a65c62aaa6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698