Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1328273002: Explicitly document that NavigationRegion.targets cannot be empty. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Explicitly document that NavigationRegion.targets cannot be empty. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c67b274852c00e184552b6119fb0c2c77361f3c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/NavigationRegion.java View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-08 20:09:48 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-08 20:15:24 UTC) #2
scheglov
5 years, 3 months ago (2015-09-08 20:16:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c67b274852c00e184552b6119fb0c2c77361f3c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698