Issue 1328213003: Fix tests that explicitly part in io library files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328213003: Fix tests that explicitly part in io library files (Closed)

Created:
5 years, 3 months ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix tests that explicitly part in io library files R=sgjesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c99e5c02fa68a6c583c746b34768e9f6882185b8

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	tests/standalone/io/http_cookie_date_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_headers_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_parser_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

analyzer does not like them: http://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/3426/steps/tests%20--host-checked/logs/stdio

5 years, 3 months ago (2015-09-08 10:19:41 UTC) #2

ricow1

Committed patchset #1 (id:1) manually as c99e5c02fa68a6c583c746b34768e9f6882185b8 (presubmit successful).

5 years, 3 months ago (2015-09-08 11:30:43 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages