Issue 1328123002: Revert "Handle addError on a WebSocket"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328123002: Revert "Handle addError on a WebSocket" (Closed)

Created:
5 years, 3 months ago by Søren Gjesse

Modified:
5 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Handle addError on a WebSocket" This reverts commit 373dd4b33c1efd52ef0dc0ad2a5249263b6b506d. Timeout in tests on Windows and Mac TBR=ricow@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0124a0542e1175b0a4d5ab766731af7bfc23113d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -110 lines)			Patch
	M	sdk/lib/io/websocket_impl.dart	View		2 chunks	+0 lines, -11 lines	0 comments	Download
	M	tests/standalone/io/web_socket_error_test.dart	View		1 chunk	+0 lines, -99 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

Committed patchset #1 (id:1) manually as 0124a0542e1175b0a4d5ab766731af7bfc23113d (presubmit successful).

5 years, 3 months ago (2015-09-07 07:07:44 UTC) #2

Message was sent while issue was closed.

lgtm