Issue 1328093004: dart2js cps: Insert bounds check for removeLast() -> pop() optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328093004: dart2js cps: Insert bounds check for removeLast() -> pop() optimization. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

Somewhat embarrassing mistake. I tried to implement this using inlining, but it is non-trivial to ...

5 years, 3 months ago (2015-09-07 09:31:55 UTC) #2

asgerf

5 years, 3 months ago (2015-09-08 14:21:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a7cba674f5401597cffc0bfea69bc672264b6c0d (presubmit successful).