Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 132773006: Fix handling of CRLF line endings in Script::GetSnippet. (Closed)

Created:
6 years, 10 months ago by rmacnak
Modified:
6 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix handling of CRLF line endings in Script::GetSnippet. BUG=http://dartbug.com/16098 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=32254

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : appease analyzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -45 lines) Patch
M runtime/vm/object.cc View 1 chunk +19 lines, -21 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/method_mirror_source_line_ending_cr.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart View 1 2 1 chunk +16 lines, -21 lines 0 comments Download
A + tests/lib/mirrors/method_mirror_source_line_ending_lf.dart View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
A tests/lib/mirrors/method_mirror_source_line_ending_test.dart View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
6 years, 10 months ago (2014-02-01 01:15:48 UTC) #1
hausner
LGTM
6 years, 10 months ago (2014-02-03 16:49:43 UTC) #2
rmacnak
6 years, 10 months ago (2014-02-03 18:12:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698