Fixed the last unit test that was failing with the new task model

Fixed the last unit test that was failing with the new task model

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e84d0694671eebfc54c68bbd9384817c14beda8d

[Brian Wilkerson, 2015-09-10 20:19:56]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-09-10 20:35:38]

LGTM

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:10316: bool eraseDeclarations = true;
Why not to make it final and initialize in the constructor?

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/driver.dart (right):

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/driver.dart:106: //          String message =
workOrder.current.toString();
Do you still need this?

[Brian Wilkerson, 2015-09-10 21:00:31]

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:10316: bool eraseDeclarations = true;
> Why not to make it final and initialize in the constructor?

I debated about both approaches. This has the advantage that we don't have to
duplicate the list of parameters to 'erase' in the constructor, but at the cost
of letting the field be mutable. Not sure which is better.

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/driver.dart (right):

https://codereview.chromium.org/1327363002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/driver.dart:106: //          String message =
workOrder.current.toString();
> Do you still need this?

Technically, no, but it was *very* useful for debugging and I expect to use it
again. Basically, this method returns 'null' if a task fails with an exception,
and after this method returns it's very hard to figure out what the exception
was. The commented out code propagates the exception so that tests will include
the stack trace in their output.

[Brian Wilkerson, 2015-09-11 15:47:09]

Committed patchset #1 (id:1) manually as
e84d0694671eebfc54c68bbd9384817c14beda8d (presubmit successful).