Issue 1326913003: dart2js cps: Insert refinements for identical(x, null) in condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1326913003: dart2js cps: Insert refinements for identical(x, null) in condition. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Insert refinements for identical(x, null) in condition. The unsugaring pass inserts an `identical(x, null)` check in the beginning of each implementation of ==. We should refine the type of `x` after that check. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/c4546e8bb681613f112912c010cb381e48351bba

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/insert_refinements.dart	View		1 chunk	+28 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 3 months ago (2015-09-03 16:42:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c4546e8bb681613f112912c010cb381e48351bba (presubmit successful).