Add resource metadata for open files.

Add resource metadata for open files.

Start tracking the read/write information for files in the new
resource management class.

There is currently no time information, I will refactor the timings so that the
static stopwatch from the socket_patch class is moved into the resource class
instead in a follow up (keeping this simply and only about the file addition).

The testing setup may seem a bit strange, but it is the only way I
seem to be able to guarantee that setup actually finishes and that we
get it cleaned up. John may know of a better way


R=sgjesse@google.com, johnmccutchan@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/db0d25efd150c8e39fc1c365a9ae9efab525ad1d

[Søren Gjesse, 2015-09-08 07:55:54]

lgtm

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/file_service_test.dart (right):

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/file_service_test.dart:72: // Initial.
Not sure what that comment means.

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/file_service_test.dart:78: print(result);
Debug print.

[ricow1, 2015-09-08 09:26:38]

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/file_service_test.dart (right):

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/file_service_test.dart:72: // Initial.
On 2015/09/08 07:55:54, Søren Gjesse wrote:
> Not sure what that comment means.
I am not completely sure either :-)

https://codereview.chromium.org/1326703004/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/file_service_test.dart:78: print(result);
On 2015/09/08 07:55:54, Søren Gjesse wrote:
> Debug print.

Done.

[ricow1, 2015-09-08 09:27:17]

Committed patchset #3 (id:40001) manually as
db0d25efd150c8e39fc1c365a9ae9efab525ad1d (presubmit successful).

[Ivan Posva, 2015-09-08 18:06:36]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-09-08 18:06:37]

DBC

-Ivan

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:597: // open.
Correct, this should be done with the overall initialization of the dart:io
library when it has been loaded by the embedder. I will be looking at different
ways of loading the dart:io library into isolates in the near future, so this
might be rolled into that work.

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/io_resource_...
File sdk/lib/io/io_resource_info.dart (right):

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:34: // TODO(ricow): Move stopwatch into this
class and use it for both files
Can you please explain what you mean by moving stopwatch into this class? Do you
mean adding a stopwatch instance? Not moving the stopwatch implementation,
correct?

[ricow1, 2015-09-08 18:33:39]

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/io_resource_...
File sdk/lib/io/io_resource_info.dart (right):

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:34: // TODO(ricow): Move stopwatch into this
class and use it for both files
On 2015/09/08 18:06:36, Ivan Posva wrote:
> Can you please explain what you mean by moving stopwatch into this class? Do
you
> mean adding a stopwatch instance? Not moving the stopwatch implementation,
> correct?

Correct. You can see the follow up here:
https://codereview.chromium.org/1320023008/

[Cutch, 2015-09-10 14:42:44]

DBC-

Looks good to me. I'm glad that you put this in the shared dart:io source files
(will be easier to get the mojo implementation working).

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:597: // open.
On 2015/09/08 18:06:36, Ivan Posva wrote:
> Correct, this should be done with the overall initialization of the dart:io
> library when it has been loaded by the embedder. I will be looking at
different
> ways of loading the dart:io library into isolates in the near future, so this
> might be rolled into that work.

We probably also need to do this automatically for libraries with service
extensions.

[ricow1, 2015-09-10 14:45:33]

On 2015/09/10 14:42:44, Cutch wrote:
> DBC-
> 
> Looks good to me. I'm glad that you put this in the shared dart:io source
files
> (will be easier to get the mojo implementation working).
> 
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.dart
> File sdk/lib/io/file_impl.dart (right):
> 
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.da...
> sdk/lib/io/file_impl.dart:597: // open.
> On 2015/09/08 18:06:36, Ivan Posva wrote:
> > Correct, this should be done with the overall initialization of the dart:io
> > library when it has been loaded by the embedder. I will be looking at
> different
> > ways of loading the dart:io library into isolates in the near future, so
this
> > might be rolled into that work.
> 
> We probably also need to do this automatically for libraries with service
> extensions.

Just let me know where to put this, and I will move the 3 current special cases
into that location.

[Cutch, 2015-09-10 16:37:50]

On 2015/09/10 14:45:33, ricow1 wrote:
> On 2015/09/10 14:42:44, Cutch wrote:
> > DBC-
> > 
> > Looks good to me. I'm glad that you put this in the shared dart:io source
> files
> > (will be easier to get the mojo implementation working).
> > 
> >
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.dart
> > File sdk/lib/io/file_impl.dart (right):
> > 
> >
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.da...
> > sdk/lib/io/file_impl.dart:597: // open.
> > On 2015/09/08 18:06:36, Ivan Posva wrote:
> > > Correct, this should be done with the overall initialization of the
dart:io
> > > library when it has been loaded by the embedder. I will be looking at
> > different
> > > ways of loading the dart:io library into isolates in the near future, so
> this
> > > might be rolled into that work.
> > 
> > We probably also need to do this automatically for libraries with service
> > extensions.
> 
> Just let me know where to put this, and I will move the 3 current special
cases
> into that location.

Re testing- we should make testeeBefore return a future and await on that before
executing tests. There is no need to cleanup after yourself, the testee is
killed automatically.

[ricow1, 2015-09-10 16:42:13]

On 2015/09/10 16:37:50, Cutch wrote:
> On 2015/09/10 14:45:33, ricow1 wrote:
> > On 2015/09/10 14:42:44, Cutch wrote:
> > > DBC-
> > > 
> > > Looks good to me. I'm glad that you put this in the shared dart:io source
> > files
> > > (will be easier to get the mojo implementation working).
> > > 
> > >
> >
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.dart
> > > File sdk/lib/io/file_impl.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1326703004/diff/40001/sdk/lib/io/file_impl.da...
> > > sdk/lib/io/file_impl.dart:597: // open.
> > > On 2015/09/08 18:06:36, Ivan Posva wrote:
> > > > Correct, this should be done with the overall initialization of the
> dart:io
> > > > library when it has been loaded by the embedder. I will be looking at
> > > different
> > > > ways of loading the dart:io library into isolates in the near future, so
> > this
> > > > might be rolled into that work.
> > > 
> > > We probably also need to do this automatically for libraries with service
> > > extensions.
> > 
> > Just let me know where to put this, and I will move the 3 current special
> cases
> > into that location.
> 
> Re testing- we should make testeeBefore return a future and await on that
before
> executing tests. There is no need to cleanup after yourself, the testee is
> killed automatically.

Two things:
  - I want to clean up the files I create! (or the bots will eventually fill up
:-) )
  - For processes, when you do a Process.run, and then kill the program doing
that, you orphan the child process and it will keep on running (this is not
really relevant here, but it is here:
https://codereview.chromium.org/1331033003/ )