Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 132623007: Fix snapshotting of TypeArguments. (Closed)

Created:
6 years, 10 months ago by regis
Modified:
6 years, 10 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix snapshotting of TypeArguments. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32457

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/vm/dart_api_message.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
6 years, 10 months ago (2014-02-07 22:54:09 UTC) #1
siva
LGTM after you remove the assert
6 years, 10 months ago (2014-02-07 23:02:26 UTC) #2
regis
6 years, 10 months ago (2014-02-07 23:02:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698