Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1325963002: Don't stop the event handler (Closed)

Created:
5 years, 3 months ago by zra
Modified:
5 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't stop the event handler. The EventHandler can't be stopped until Dart_Cleanup shuts down all isolates and cleans up all VM thread pool threads. TBR BUG= Committed: https://github.com/dart-lang/sdk/commit/98384272a5fbd28655521f1f6f74bfd8e8cfda6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M runtime/bin/main.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M runtime/bin/process.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
zra
Committed patchset #1 (id:1) manually as 98384272a5fbd28655521f1f6f74bfd8e8cfda6b (presubmit successful).
5 years, 3 months ago (2015-09-02 03:33:42 UTC) #1
zra
5 years, 3 months ago (2015-09-02 03:34:09 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698