Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325903002: Make markdown error-free in strong mode. (Closed)

Created:
5 years, 3 months ago by Bob Nystrom
Modified:
5 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/markdown.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make markdown error-free in strong mode. Fix #40. R=nweiz@google.com Committed: 2b8c4dbf18b5767aa9099b850bc634e57c5c2951

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M CHANGELOG.md View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/inline_parser.dart View 6 chunks +35 lines, -32 lines 2 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/markdown_test.dart View 3 chunks +2 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
5 years, 3 months ago (2015-09-01 20:15:35 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1325903002/diff/1/lib/src/inline_parser.dart File lib/src/inline_parser.dart (right): https://codereview.chromium.org/1325903002/diff/1/lib/src/inline_parser.dart#newcode294 lib/src/inline_parser.dart:294: /// Given that [match] has matched both a ...
5 years, 3 months ago (2015-09-01 20:51:42 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as 2b8c4dbf18b5767aa9099b850bc634e57c5c2951 (presubmit successful).
5 years, 3 months ago (2015-09-01 21:14:25 UTC) #4
Bob Nystrom
5 years, 3 months ago (2015-09-01 21:14:58 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1325903002/diff/1/lib/src/inline_parser.dart
File lib/src/inline_parser.dart (right):

https://codereview.chromium.org/1325903002/diff/1/lib/src/inline_parser.dart#...
lib/src/inline_parser.dart:294: /// Given that [match] has matched both a title
and URL, creates an <a>
On 2015/09/01 20:51:42, nweiz wrote:
> Nit: `<a>`

Done.

https://codereview.chromium.org/1325903002/diff/1/test/markdown_test.dart
File test/markdown_test.dart (right):

https://codereview.chromium.org/1325903002/diff/1/test/markdown_test.dart#new...
test/markdown_test.dart:1285: Node nyanResolver(String text) => new
Text('~=[,,_${text}_,,]:3');
On 2015/09/01 20:51:42, nweiz wrote:
> :(

<shrug> Small price to pay overall for better static checking.

Powered by Google App Engine
This is Rietveld 408576698