Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1325143003: Issue 24277. Use node's offset as the source range start for the first unit node in Outline. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24277. Use node's offset as the source range start for the first unit node in Outline. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24277 Committed: https://github.com/dart-lang/sdk/commit/e090ff872e5d8649ccf06023bd9c34a51b1ab446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 10 chunks +47 lines, -23 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-02 22:10:39 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-03 00:52:22 UTC) #2
scheglov
5 years, 3 months ago (2015-09-03 00:55:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e090ff872e5d8649ccf06023bd9c34a51b1ab446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698