Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1325133002: Improve performance by not doing binary searches. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/yaml@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve performance by not doing binary searches. Normally getting the line and column of a SpanScanner or a SourceLocation needs a binary search through all the line endings in the source file. This CL avoids those searches by using an eager SpanScanner which does extra computation to track its current line and column position, and storing the line and column directly on _SimpleKey objects. See #12 R=rnystrom@google.com Committed: https://github.com/dart-lang/yaml/commit/df28edda6846b052d75aea0585b8d8aa250d96f2

Patch Set 1 #

Patch Set 2 : Re-add "-dev" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M lib/src/scanner.dart View 7 chunks +21 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 3 months ago (2015-09-02 18:49:28 UTC) #1
Bob Nystrom
lgtm
5 years, 3 months ago (2015-09-02 19:40:41 UTC) #2
nweiz
5 years, 3 months ago (2015-09-02 20:34:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
df28edda6846b052d75aea0585b8d8aa250d96f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698