Issue 13251003: pkg/unittest: readonly view of testCase collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13251003: pkg/unittest: readonly view of testCase collection (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), gram, Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: readonly view of testCase collection Committed: https://code.google.com/p/dart/source/detail?r=20658

Patch Set 2 : something real #

Total comments: 1

Patch Set 3 : removed unused field while I'm at it #

Patch Set 4 : nit #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -47 lines)			Patch
M	pkg/unittest/lib/src/config.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View	1 2 3	17 chunks	+43 lines, -43 lines	0 comments	Download
M	pkg/unittest/test/unittest_test.dart	View	1	3 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

All sorts of things can get very broken if a user starts mucking with the ...

7 years, 9 months ago (2013-03-29 00:50:32 UTC) #1

gram

lgtm with one small nit https://codereview.chromium.org/13251003/diff/1001/pkg/unittest/lib/unittest.dart File pkg/unittest/lib/unittest.dart (right): https://codereview.chromium.org/13251003/diff/1001/pkg/unittest/lib/unittest.dart#newcode275 pkg/unittest/lib/unittest.dart:275: _soloTest = new TestCase._internal(_testCases.length ...

7 years, 9 months ago (2013-03-29 00:57:39 UTC) #2