Issue 1325053003: Copy libraries to prepare for move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1325053003: Copy libraries to prepare for move (Closed)

Created:
5 years, 3 months ago by Johnni Winther

Modified:
5 years, 3 months ago

Reviewers:
karlklose, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Copy libraries to prepare for move The plan: Move ElementListener from listener.dart to element_listener.dart Move NodeListener from listener.dart to node_listener.dart Move MemberListener from class_element_parser.dart to member_listener.dart Move PartialElement, PartialFunctionElement etc from listener.dart and class_element_parser.dart to partial_elements.dart Move PrecedenceInfo from token.dart to precedence.dart Move *_INFO constants from token.dart to precendence_constants.dart Move *_TOKEN constants from token.dart to token_constants.dart BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/3fbe395529b6d635194c917bd3d4e62be0677ab9

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A +	pkg/compiler/lib/src/parser/element_listener.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/parser/member_listener.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/parser/node_listener.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/parser/partial_elements.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/tokens/precedence.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/tokens/precedence_constants.dart	View	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/tokens/token_constants.dart	View	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

5 years, 3 months ago (2015-09-02 10:40:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fbe395529b6d635194c917bd3d4e62be0677ab9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages