Issue 1325013002: Add a parsing benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1325013002: Add a parsing benchmark. (Closed)

Created:
5 years, 3 months ago by Bob Nystrom

Modified:
5 years, 3 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/yaml.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a parsing benchmark. R=nweiz@google.com Committed: https://github.com/dart-lang/yaml/commit/a080e6b8b0b2609858a755797386079c20c2aa02

Patch Set 1 #

Total comments: 2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -0 lines)			Patch
A	benchmark/benchmark.dart	View	1 chunk	+74 lines, -0 lines	2 comments	Download
A	benchmark/input.yaml	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A	benchmark/output.json	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

lgtm https://codereview.chromium.org/1325013002/diff/1/benchmark/benchmark.dart File benchmark/benchmark.dart (right): https://codereview.chromium.org/1325013002/diff/1/benchmark/benchmark.dart#newcode21 benchmark/benchmark.dart:21: var best = 99999999.0; double.INFINITY ;)

5 years, 3 months ago (2015-09-02 00:00:35 UTC) #3

Bob Nystrom

Committed patchset #1 (id:1) manually as a080e6b8b0b2609858a755797386079c20c2aa02 (presubmit successful).

5 years, 3 months ago (2015-09-02 00:08:25 UTC) #4

Bob Nystrom

5 years, 3 months ago (2015-09-02 00:08:31 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1325013002/diff/1/benchmark/benchmark.dart
File benchmark/benchmark.dart (right):

https://codereview.chromium.org/1325013002/diff/1/benchmark/benchmark.dart#ne...
benchmark/benchmark.dart:21: var best = 99999999.0;
On 2015/09/02 00:00:35, nweiz wrote:
> double.INFINITY ;)

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages