Issue 1324543002: Fix a bug PauseOnExit notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1324543002: Fix a bug PauseOnExit notification. (Closed)

Created:
5 years, 3 months ago by turnidge

Modified:
5 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a bug PauseOnExit notification. When we notified before, we could end up entering an isolate when it was busy handling another message. By moving the notification up and clearing the "task" later, we ensure that we own the isolate for the duration of the notification. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/01c1d2c667acd50e74d7c5c9fa1b157c57e9b348

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -15 lines)			Patch
	M	runtime/vm/message_handler.cc	View	1 2	3 chunks	+30 lines, -15 lines	0 comments	Download

Total messages: 5 (1 generated)

turnidge

5 years, 3 months ago (2015-08-28 20:19:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
01c1d2c667acd50e74d7c5c9fa1b157c57e9b348 (presubmit successful).