Issue 24298. Fix for 'async' function body conversion.

Issue 24298. Fix for 'async' function body conversion.

R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298

Committed: https://github.com/dart-lang/sdk/commit/f0cbf430e000bd163097f913f3087f4fa343c593

[Paul Berry, 2015-09-05 03:42:35]

lgtm

https://codereview.chromium.org/1324323004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/1324323004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1929: }
I don't think "sync*" or "async*" functions will ever be eligible for "convert
to block function body" or "convert to expression function body", but as long as
you're handling the "async*" case, might as well handle "sync*" as well.

[scheglov, 2015-09-05 04:38:13]

https://codereview.chromium.org/1324323004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/1324323004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1929: }
On 2015/09/05 03:42:35, Paul Berry wrote:
> I don't think "sync*" or "async*" functions will ever be eligible for "convert
> to block function body" or "convert to expression function body", but as long
as
> you're handling the "async*" case, might as well handle "sync*" as well.

Good idea.
I will disable converting for generators and git rid of this function.

[scheglov, 2015-09-05 04:39:33]

Committed patchset #1 (id:1) manually as
f0cbf430e000bd163097f913f3087f4fa343c593 (presubmit successful).