Line-breaking plumbing and bits and pieces.

Line-breaking plumbing and bits and pieces.

Some tentative abstractions for implementing simple line breaking algorithms.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31683

[pquitslund, 2014-01-09 19:03:30]

Very much a work in progress but hopefully a good jumping off point for further
investigations...

[Brian Wilkerson, 2014-01-09 19:29:23]

LGTM

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:69: List<Chunk> breakLine(Line line) {
Try as I might, I don't understand how this method works. Perhaps it's because I
have no idea what a "tent" is in this context. (Some comments might help :-)

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:211: final buffer = new
StringBuffer();
Not sure why you deleted the type. Because this isn't a private field it's
getter is part of the public API, so I would have expected a type. (Mostly just
curious.)

[pquitslund, 2014-01-09 23:04:11]

Thanks!

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:69: List<Chunk> breakLine(Line line) {
On 2014/01/09 19:29:24, Brian Wilkerson wrote:
> Try as I might, I don't understand how this method works. Perhaps it's because
I
> have no idea what a "tent" is in this context. (Some comments might help :-)

Ah yes.  'tent' was short-hand for 'tentative'.  Anyway, I've added some
comments to de-obfuscate a bit.  I'll do more on the next pass as well.

https://codereview.chromium.org/132383002/diff/50001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:211: final buffer = new
StringBuffer();
On 2014/01/09 19:29:24, Brian Wilkerson wrote:
> Not sure why you deleted the type. Because this isn't a private field it's
> getter is part of the public API, so I would have expected a type. (Mostly
just
> curious.)

That was overzealous on my part.  Added back.

[pquitslund, 2014-01-09 23:04:38]

Committed patchset #3 manually as r31683 (presubmit successful).