Issue 1323183002: Revert "Extract meta data about open sockets into separate class."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323183002: Revert "Extract meta data about open sockets into separate class." (Closed)

Created:
5 years, 3 months ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Extract meta data about open sockets into separate class." This reverts commit 01eff8ce18be7eceb6ce0be1097005965edf2588. Seeing issues on windows and on dart2js R=sgjesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/665f397bb893413e914fa518f2baefe54b05317d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -458 lines)			Patch
M	runtime/bin/socket_patch.dart	View	20 chunks	+151 lines, -67 lines	0 comments	Download
D	runtime/observatory/tests/service/tcp_socket_service_test.dart	View	1 chunk	+0 lines, -157 lines	0 comments	Download
D	runtime/observatory/tests/service/udp_socket_service_test.dart	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	sdk/lib/io/io.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	sdk/lib/io/io_resource_info.dart	View	1 chunk	+0 lines, -159 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

ricow1

Committed patchset #1 (id:1) manually as 665f397bb893413e914fa518f2baefe54b05317d (presubmit successful).

5 years, 3 months ago (2015-09-02 14:19:41 UTC) #2

Message was sent while issue was closed.

lgtm :-(