Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 132313012: Fix typechecks for constant assignments of function to typedefs. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Fix typechecks for constant assignments of function to typedefs. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32432

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Patch Set 3 : Update status file for analyzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M sdk/lib/_internal/compiler/implementation/constants.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/type_check_const_function_typedef2_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + tests/language/type_check_const_function_typedef_test.dart View 1 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
6 years, 10 months ago (2014-02-07 13:29:16 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/132313012/diff/1/tests/language/type_check_const_function_typedef2_test.dart File tests/language/type_check_const_function_typedef2_test.dart (right): https://codereview.chromium.org/132313012/diff/1/tests/language/type_check_const_function_typedef2_test.dart#newcode16 tests/language/type_check_const_function_typedef2_test.dart:16: int /// 00: compile-time error, static type warning ...
6 years, 10 months ago (2014-02-07 13:38:43 UTC) #2
floitsch
https://codereview.chromium.org/132313012/diff/1/tests/language/type_check_const_function_typedef2_test.dart File tests/language/type_check_const_function_typedef2_test.dart (right): https://codereview.chromium.org/132313012/diff/1/tests/language/type_check_const_function_typedef2_test.dart#newcode16 tests/language/type_check_const_function_typedef2_test.dart:16: int /// 00: compile-time error, static type warning On ...
6 years, 10 months ago (2014-02-07 13:47:17 UTC) #3
karlklose
SLGTM.
6 years, 10 months ago (2014-02-07 13:57:53 UTC) #4
floitsch
6 years, 10 months ago (2014-02-07 16:53:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r32432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698