Implement task to infer instance members

Implement task to infer instance members

R=leafp@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/de4280fa14695167cd9341fb217fbac59f19c926

[Brian Wilkerson, 2015-08-31 20:15:46]

brianwilkerson@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com

[Brian Wilkerson, 2015-08-31 20:15:46]

This creates a task to perform the instance member inference that was
implemented in an earlier CL.

[Paul Berry, 2015-08-31 20:39:24]

lgtm.  The comments below are just nits.

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:3064: if (unitMember == null) {
Nit: since this is test code, I don't think it's necessary to program
defensively.  Consider just changing this to "expect(unitMember, isNotNull)". 
This will have the advantage that if unitMember ever is null, the unit test
stack trace will give slightly more information about the cause of the problem.

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:3075: return null;
Similarly, consider changing this to something like "fail('No method named
$methodName found');"

[Leaf, 2015-08-31 21:11:32]

lgtm

[Brian Wilkerson, 2015-08-31 21:23:34]

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:3064: if (unitMember == null) {
Based on the next comment, I just put a call to 'fail' in 'getClass' if no class
is found.

https://codereview.chromium.org/1322983002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:3075: return null;
I added the file (but can't remove the return without producing a hint).

[Brian Wilkerson, 2015-08-31 21:23:48]

Committed patchset #1 (id:1) manually as
de4280fa14695167cd9341fb217fbac59f19c926 (presubmit successful).