Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322973007: Use memory compiler in compiler_helper.dart. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : Update cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -140 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 3 chunks +34 lines, -32 lines 0 comments Download
A pkg/compiler/lib/src/commandline_options.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 6 chunks +38 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/helpers/trace.dart View 1 2 chunks +23 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer_names.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 1 12 chunks +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/arithmetic_simplification_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/array_tracing_mirror_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/bad_loop_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/codegen_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 4 chunks +65 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/dictionary_types_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/frontend_checker.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/in_user_code_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_spec_optimization_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/pretty_parameter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/show_package_warnings_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/space_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/use_checks_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/value_range3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/warnings_checker.dart View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart File pkg/compiler/lib/src/helpers/trace.dart (right): https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart#newcode134 pkg/compiler/lib/src/helpers/trace.dart:134: // #n <method-name> (<uri>) Needed to support async bodies.
5 years, 3 months ago (2015-09-09 13:43:07 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart File pkg/compiler/lib/src/helpers/trace.dart (right): https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart#newcode134 pkg/compiler/lib/src/helpers/trace.dart:134: // #n <method-name> (<uri>) On 2015/09/09 13:43:07, Johnni ...
5 years, 3 months ago (2015-09-10 06:37:51 UTC) #3
Johnni Winther
https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart File pkg/compiler/lib/src/helpers/trace.dart (right): https://codereview.chromium.org/1322973007/diff/1/pkg/compiler/lib/src/helpers/trace.dart#newcode134 pkg/compiler/lib/src/helpers/trace.dart:134: // #n <method-name> (<uri>) On 2015/09/10 06:37:51, sigurdm wrote: ...
5 years, 3 months ago (2015-09-11 10:42:06 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-11 10:49:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8bcbccc067ccac48ce9d4644c49a0542ba9dab3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698