Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322973006: Symbols::NewFormatted and old space allocation. (Closed)

Created:
5 years, 3 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : synced #

Total comments: 2

Patch Set 3 : More concat elimination #

Patch Set 4 : Address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -34 lines) Patch
M runtime/vm/ast_transformer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 10 chunks +43 lines, -31 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
srdjan
5 years, 3 months ago (2015-09-03 23:09:43 UTC) #2
srdjan
5 years, 3 months ago (2015-09-04 16:51:22 UTC) #3
hausner
LGTM with comment https://codereview.chromium.org/1322973006/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1322973006/diff/20001/runtime/vm/parser.cc#newcode11947 runtime/vm/parser.cc:11947: const char* key = Z->PrintToString("%s_%" Pd ...
5 years, 3 months ago (2015-09-04 17:35:29 UTC) #4
srdjan
Committed patchset #4 (id:60001) manually as 771f2dfb526eee4e0e36715ae7778fb9f6f9a5c2 (presubmit successful).
5 years, 3 months ago (2015-09-04 17:59:38 UTC) #5
srdjan
5 years, 2 months ago (2015-09-29 23:08:25 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1322973006/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1322973006/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:11947: const char* key = Z->PrintToString("%s_%" Pd "",
On 2015/09/04 17:35:29, hausner wrote:
> I think you can use Symbol::NewFormatted here too.

Done.

Powered by Google App Engine
This is Rietveld 408576698