Add download of the stable SDK from gcloud to the gclient hooks in DEPS.

Add download of the stable SDK from gcloud to the gclient hooks in DEPS.

This will be used for the observatory build, and to replace testing/bin.

BUG=https://github.com/dart-lang/sdk/issues/24053
R=iposva@google.com, ricow@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c88126f7dee91627c6f6b6d6faa1cfa7be82001

[Bill Hesse, 2015-09-01 15:36:29]

whesse@google.com changed reviewers:
+ iposva@google.com, ricow@google.com

[ricow1, 2015-09-02 06:12:04]

lgtm
Ivan: you previously had concerns that you only get binaries for the OS you are
on (e.g., if you mount your linux drive on you mac, then build without gclient
sync, you would get a build error). Are you ok with this (I have no strong
feelings towards all or one)
You should also update tools/create_tarball.py to not add these to the exclude
list

https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEPS
File tools/deps/dartium.deps/DEPS (right):

https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEP...
tools/deps/dartium.deps/DEPS:232: hooks.append({
this should eventually go away right? do we track that?

[Ivan Posva, 2015-09-02 06:52:28]

On 2015/09/02 06:12:04, ricow1 wrote:
> lgtm

> Ivan: you previously had concerns that you only get binaries for the OS you
are
> on (e.g., if you mount your linux drive on you mac, then build without gclient
> sync, you would get a build error). Are you ok with this (I have no strong
> feelings towards all or one)

Calling "gclient sync" on different platforms messes with the checked out files
because the different tool versions (git or svn) are always slightly out of
sync. But this appears to be in the "hooks" section, so just running "gclient
runhooks" should actually populate the SDKs on the relevant platforms, do I
understand this correctly?

-Ivan

> You should also update tools/create_tarball.py to not add these to the exclude
> list
> 
> https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEPS
> File tools/deps/dartium.deps/DEPS (right):
> 
>
https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEP...
> tools/deps/dartium.deps/DEPS:232: hooks.append({
> this should eventually go away right? do we track that?

[ricow1, 2015-09-02 06:54:09]

On 2015/09/02 06:52:28, Ivan Posva wrote:
> On 2015/09/02 06:12:04, ricow1 wrote:
> > lgtm
> 
> > Ivan: you previously had concerns that you only get binaries for the OS you
> are
> > on (e.g., if you mount your linux drive on you mac, then build without
gclient
> > sync, you would get a build error). Are you ok with this (I have no strong
> > feelings towards all or one)
> 
> Calling "gclient sync" on different platforms messes with the checked out
files
> because the different tool versions (git or svn) are always slightly out of
> sync. But this appears to be in the "hooks" section, so just running "gclient
> runhooks" should actually populate the SDKs on the relevant platforms, do I
> understand this correctly?
Correct (I guess you need to run that anyway to get the xcode build files,
unless you run gyp manually)

Cheers
Rico
> 
> -Ivan
> 
> > You should also update tools/create_tarball.py to not add these to the
exclude
> > list
> > 
> >
https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEPS
> > File tools/deps/dartium.deps/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEP...
> > tools/deps/dartium.deps/DEPS:232: hooks.append({
> > this should eventually go away right? do we track that?

[Ivan Posva, 2015-09-02 06:55:32]

On 2015/09/02 06:54:09, ricow1 wrote:
> On 2015/09/02 06:52:28, Ivan Posva wrote:
> > On 2015/09/02 06:12:04, ricow1 wrote:
> > > lgtm
> > 
> > > Ivan: you previously had concerns that you only get binaries for the OS
you
> > are
> > > on (e.g., if you mount your linux drive on you mac, then build without
> gclient
> > > sync, you would get a build error). Are you ok with this (I have no strong
> > > feelings towards all or one)
> > 
> > Calling "gclient sync" on different platforms messes with the checked out
> files
> > because the different tool versions (git or svn) are always slightly out of
> > sync. But this appears to be in the "hooks" section, so just running
"gclient
> > runhooks" should actually populate the SDKs on the relevant platforms, do I
> > understand this correctly?
> Correct (I guess you need to run that anyway to get the xcode build files,
> unless you run gyp manually)

Thanks for verifying.

LGTM as well...

-Ivan

> 
> Cheers
> Rico
> > 
> > -Ivan
> > 
> > > You should also update tools/create_tarball.py to not add these to the
> exclude
> > > list
> > > 
> > >
> https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEPS
> > > File tools/deps/dartium.deps/DEPS (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1322753005/diff/1/tools/deps/dartium.deps/DEP...
> > > tools/deps/dartium.deps/DEPS:232: hooks.append({
> > > this should eventually go away right? do we track that?

[Bill Hesse, 2015-09-02 11:11:47]

Committed patchset #2 (id:20001) manually as
0c88126f7dee91627c6f6b6d6faa1cfa7be82001 (presubmit successful).