Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 132193004: Don't throw an error if a scheduled process exits early. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't throw an error if a scheduled process exits early. Early exits are expected in some cases, since a process's stdout and stderr streams can close later than the process itself exits. Throwing an error caused some race conditions. Instead, ScheduledProcess now prints additional debug info if an error occurs when a test exited earlier than expected. R=rnystrom@google.com BUG=15654 Committed: https://code.google.com/p/dart/source/detail?r=31686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M pkg/scheduled_test/lib/scheduled_process.dart View 6 chunks +30 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 11 months ago (2014-01-09 22:29:41 UTC) #1
Bob Nystrom
6 years, 11 months ago (2014-01-09 22:51:12 UTC) #2
Bob Nystrom
lgtm
6 years, 11 months ago (2014-01-09 22:51:14 UTC) #3
nweiz
6 years, 11 months ago (2014-01-10 01:32:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698