Issue 132193002: Port Try Dart! to SDK 1.0.

Issue 132193002: Port Try Dart! to SDK 1.0. (Closed)

Created:
6 years, 11 months ago by ahe

Modified:
6 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Port Try Dart! to SDK 1.0. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=31737

Patch Set 3 : Remove unneeded file, update AppCache manifest. #

Total comments: 8

Patch Set 4 : Address Kasper's comments. #

Patch Set 5 : Merged with r31735. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -279 lines)			Patch
A	dart/site/try/Makefile	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	dart/site/try/app.yaml	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	dart/site/try/compiler_isolate.dart	View		3 chunks	+9 lines, -7 lines	0 comments	Download
D	dart/site/try/deploy.sh	View	1 2	1 chunk	+0 lines, -18 lines	0 comments	Download
M	dart/site/try/index.html	View		3 chunks	+3 lines, -3 lines	0 comments	Download
A	dart/site/try/isolate_legacy.dart	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download
M	dart/site/try/jsonify.dart	View		1 chunk	+4 lines, -167 lines	0 comments	Download
M	dart/site/try/leap.dart	View	1 2 3	23 chunks	+114 lines, -74 lines	0 comments	Download
M	dart/site/try/nossl.appcache	View	1 2	2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! Awesome stuff. https://codereview.chromium.org/132193002/diff/50001/dart/site/try/isolate_legacy.dart File dart/site/try/isolate_legacy.dart (right): https://codereview.chromium.org/132193002/diff/50001/dart/site/try/isolate_legacy.dart#newcode1 dart/site/try/isolate_legacy.dart:1: // Copyright (c) 2013, the Dart ...

6 years, 11 months ago (2014-01-09 18:44:01 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/132193002/diff/50001/dart/site/try/isolate_legacy.dart File dart/site/try/isolate_legacy.dart (right): https://codereview.chromium.org/132193002/diff/50001/dart/site/try/isolate_legacy.dart#newcode1 dart/site/try/isolate_legacy.dart:1: // Copyright (c) 2013, the Dart ...

6 years, 11 months ago (2014-01-13 15:36:01 UTC) #3

ahe

6 years, 11 months ago (2014-01-13 15:38:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r31737 (presubmit successful).

Expand Messages | Collapse Messages